How we fixed map overbright

Talk about anything related to Unvanquished.
User avatar
illwieckz
Project Head
Posts: 854
Joined: Sat Aug 11, 2012 7:22 pm UTC
Location: France

How we fixed map overbright

Post by illwieckz »

In our Renderer FAQ we have this statement:

  • Q: Did the overbright patches change the way legacy maps are rendered?
  • A: No, they restored the way legacy maps were rendered. Previously we had a bug, so if you see a change, it's because a bug was misrendering something before.

It may look like a very bold statement and some people may actually believe it's not true, after all there are some unlucky players around there that may have never played without overbright bugs since 30 years (that's very sad, truly).

The FAQ also states this:

  • Q: Is the original overbright configuration used when rendering legacy maps?
  • A: Yes, when rendering legacy maps (or maps built the old way), the default overbright settings are the ones from the reference id Tech 3 experience which was “players playing full-screen on Windows”, we also have historical screenshots showing unambiguously that such overbright configuration was the expected behaviour in Tremulous time as well.

So, here comes the proof:

✅️ Tremulous 1.1.0, Windows (2006 build)❌️ Tremulous 1.2.0 GPP, Linux (2009 build)
ImageImage
✅️ GrangerHub Tremulous 1.3.0a-0.12 (ioq3 renderer), Linux (2017 build)❌️ Unvanquished 0.54.1, Linux (2023 build)
ImageImage
✅️ Unvanquished 0.56.2, Linux (2026 build)🔥️ Unvanquished 0.56.2 (with tone mapping), Linux (2026 build)
ImageImage

As we can see, the 0.56.2 render without tone mapping is the closest render to Tremulous 1.1.0 on Windows (the reference renderer) and to the ioq3 renderer used by GrangerHub Tremulous 1.3.0. So yes overbright has indeed been fixed.

It happened that Both Tremulous 1.1.0 on Linux, Tremulous 1.2.0 on Linux and Unvanquished before 0.55 shared the same bug that that was initially a Quake 3 linux bug, that bug destroyed 75% of the precomputed light data at render time.

And I will emphasis on this statement: if you do believe the Tremulous 1.2.0 and Unvanquished 0.54.1 render are the correct ones and the ones you expect, that's because 30 years of bugs have built up wrong expectations in you, you may have never seen the light at all (no pun intended) because the renderer was destroying 75% of it.

That bug was initially a bug in the Quake 3 engine for Linux and Linux players got a subpar implementation at the time, and this bug extended to over platforms over time when the Windows-specific overbright implementation had been dropped in some of Dæmon's parent (XreaL or Tremulous GPP, I don't know).

Both ioq3 and the Dæmon engine have a fixed renderer with correct overbright. It's probably true in ioq3 for more then a decade. Us only fixing it around 2024 meants we were very late at fixing that bug.

GrangerHub Tremulous started doing alpha releases based on ioq3 around 2017, 9 years ago, and them did not revert the overbright fix from upstream ioq3. That overbright we can see in both Windows Tremulous from 2006, GrangerHub Tremulous from 2017, and Unvanquished/Dæmon since around 0.55 in 2024 is the correct and expected render.

Note about the last screenshot: the tonemapping feature is purposed to rework the lighting by design, and is expected to make the image brighter with the current settings. The tonemapping feature has been first implemented to workaround Tremulous maps being too dark. A similar light intensity difference would also happen when using adaptive lighting, which requires tone mapping by the way. This is not a bug and one can disable tone mapping if he dislikes it. That is not a bug, it's a feature that was requested and praised by the players.

This comment is licensed under cc ​​by 4 and antecedent. The Dæmon Crunch tool is awesome!

User avatar
illwieckz
Project Head
Posts: 854
Joined: Sat Aug 11, 2012 7:22 pm UTC
Location: France

Re: How we fixed map overbright

Post by illwieckz »

So it would be very nice if people stop blaming developers who spent their precious time fixing bugs everyone in the id Tech 3 ecosystem is fixing since decades, to bring players the render John Carmack himself intended, and that the original Tremulous delivered, and that Tremulous revivals brought back a decade ago.

This comment is licensed under cc ​​by 4 and antecedent. The Dæmon Crunch tool is awesome!