Searching for more code reviews

Release and discuss things you've made, including mods.
User avatar
Viech
Project Head
Posts: 2137
Joined: Fri Aug 03, 2012 11:50 pm UTC
Location: Berlin

Searching for more code reviews

Postby Viech » Mon Oct 15, 2012 1:55 pm UTC

kharnov wrote:Due to our descent from Quake 3, any review of the Quake 3 engine code applies. A particularly good one can be found here, but others can be found easily through a quick Google search.

I've been reading a lot of unvanquished code lately but I think in order to get a decent overview I need either a lot more time or more documentation (and since I'm rather busy and supposed to map, I'd prefer the latter). I read Fabien Sanglard's review a while ago but didn't find anything comparable when asking the oracle.
I'd like to ask the people hwo are currently working on the code if they could share some of the resources they found particularily helpful for understanding it. It doesn't need to be directly related to quake 3 or any derived engine, I'd also be thankful for any article or book that would give me a more general overview over the technology used in our engine.
User avatar
Ishq
Project Head
Posts: 1138
Joined: Tue Mar 06, 2012 8:32 pm UTC

Re: Searching for more code reviews

Postby Ishq » Mon Oct 15, 2012 3:37 pm UTC

Specifically what parts of the code?
User avatar
velociostrich
Dragoon
Posts: 318
Joined: Thu Mar 08, 2012 6:24 pm UTC

Re: Searching for more code reviews

Postby velociostrich » Tue Oct 16, 2012 4:24 am UTC

Viech, it has been my intention to document as much of the engine as I am capable of documenting (i.e., that I am capable of wrapping my head around) on the wiki for some time, but I haven't done much of anything in that regard due to time constraints. I entreat anyone at all to assist in this process, however. For the time being, there are a few links that may be of interest on the technical documentation page of the wiki.
User avatar
Qrntz
Dragoon
Posts: 235
Joined: Wed Mar 07, 2012 7:11 pm UTC
Location: Chornobyl
Contact:

Re: Searching for more code reviews

Postby Qrntz » Tue Oct 16, 2012 7:06 am UTC

A major help is something that can follow identifiers to the place of their declaration and/or initialization. (pretty much any IDE has this)
This way, you can easily analyze seemingly mysterious code by quickly jumping to the definitions of functions that comprise its sequence.
Image
trinitrotoluene
Posts: 8
Joined: Sun Mar 11, 2012 4:38 am UTC

Re: Searching for more code reviews

Postby trinitrotoluene » Tue Oct 16, 2012 10:48 am UTC

cd src/engine
grep "int main" -r *
make popcorn


:rolleyes: :p
User avatar
Viech
Project Head
Posts: 2137
Joined: Fri Aug 03, 2012 11:50 pm UTC
Location: Berlin

Re: Searching for more code reviews

Postby Viech » Wed Oct 17, 2012 12:30 pm UTC

Ishq wrote:Specifically what parts of the code?

We spoke on IRC about this, I'm mainly looking for a rough general overview over the complete project as well as lecture that explains/reviews the methods and algorithms used.

velociostrich wrote:Viech, it has been my intention to document as much of the engine as I am capable of documenting (i.e., that I am capable of wrapping my head around) on the wiki for some time, but I haven't done much of anything in that regard due to time constraints. I entreat anyone at all to assist in this process, however. For the time being, there are a few links that may be of interest on the technical documentation page of the wiki.

Thank you, these resources seem useful!

Qrntz wrote:A major help is something that can follow identifiers to the place of their declaration and/or initialization. (pretty much any IDE has this)
This way, you can easily analyze seemingly mysterious code by quickly jumping to the definitions of functions that comprise its sequence.

I did load the code in Eclipse once, thought "this feels so wrong" and closed it. I never worked on a big enough C project to try out any IDE. Can you recommend one that 1) works with the layout of the git repo (or even knows git) and 2) doesn't mess it up with hundreds of meta files?

trinitrotoluene wrote:make popcorn

Code: Select all

~/unv/git/src/engine (git)-[master] % grep -R "int main"
sys/sys_main.c:int main( int argc, char **argv )
sys/SDLMain.m:int main ( int argc, char **argv )

I expected something more creepy to happen (such as ~/unv/git (git)-[master] % grep -R "int main"|wc -l answering 506 ... wtf).
User avatar
Ishq
Project Head
Posts: 1138
Joined: Tue Mar 06, 2012 8:32 pm UTC

Re: Searching for more code reviews

Postby Ishq » Thu Oct 18, 2012 1:03 am UTC

Ah, okay.
User avatar
gavlig
Animator
Posts: 518
Joined: Wed Mar 14, 2012 1:20 pm UTC

Re: Searching for more code reviews

Postby gavlig » Fri Oct 19, 2012 4:45 pm UTC

@Viech: QtCreator works fine as IDE for unv. Just load it from CMakeLists.txt and you have a ready-to-go project ;)
User avatar
Qrntz
Dragoon
Posts: 235
Joined: Wed Mar 07, 2012 7:11 pm UTC
Location: Chornobyl
Contact:

Re: Searching for more code reviews

Postby Qrntz » Sat Oct 20, 2012 8:13 am UTC

Viech wrote:I did load the code in Eclipse once, thought "this feels so wrong"

It sure does.

Viech wrote:I never worked on a big enough C project to try out any IDE. Can you recommend one that 1) works with the layout of the git repo (or even knows git) and 2) doesn't mess it up with hundreds of meta files?

Qt Creator to both or Vim with extensions if you're feeling hardcore.
KDevelop might be applicable but I have not tried using it for that.
Image
User avatar
Viech
Project Head
Posts: 2137
Joined: Fri Aug 03, 2012 11:50 pm UTC
Location: Berlin

Re: Searching for more code reviews

Postby Viech » Sat Oct 20, 2012 2:27 pm UTC

I used grep and vim before but tracking function calls between files was rather tedious (is there a plugin that makes this easier?). Qt Creater looks very promising and works like a charm when pointing it to the CMakeLists.txt, I will give it a try!

Return to “Community Development”

Who is online

Users browsing this forum: No registered users and 3 guests