Page 1 of 2

html page typo

Posted: Thu Nov 01, 2012 4:27 am UTC
by epicdude

there is text showing:
'); var sidebar_align = 'right'; var content_container_margin = parseInt('290px'); var sidebar_width = parseInt('270px'); //-->
on page http://unvanquished.net/forum/forum.php

there is a typo in HTML code line 100 document write has missplaced closing quoattion mark " and it should be single ' .

<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/sidebar.css?d=1333136741" />

Code: Select all

<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/widgets.css?d=1333136741" />
<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/tagcloud.css?d=1333136741" />
    <!--[if lt IE 8]><link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/sidebar-ie.css?d=1333136741" /><![endif]-->
<script type="text/javascript">
<!--
	document.write('<script type="text/javascript" src="' + yuipath + '/animation/animation-min.js?v=4111"></script>');
	var sidebar_align = 'right';
	var content_container_margin = parseInt('290px');

Re: html page typo

Posted: Fri Nov 02, 2012 4:16 am UTC
by velociostrich

I see no typo, and JSLint agrees with me. The only reasonable faults of that code is the missing radix argument to usages of parseInt.


Re: html page typo

Posted: Fri Nov 02, 2012 1:21 pm UTC
by epicdude

Looks like it was a temporary problem, now works fine.


Re: html page typo

Posted: Fri Nov 02, 2012 2:14 pm UTC
by epicdude

Bug is seen again attached

Ok the problem is not quotes (they are o.k.) but the fact that you should use CDATA in javascript blocks that are in line in html.

http://javascript.about.com/library/blxhtml.htm use for #1 or maybe #2, currently you use #3 and this causes problem


Re: html page typo

Posted: Thu Nov 29, 2012 12:16 pm UTC
by epicdude

Page is still broken, will you fix it?

'); var sidebar_align = 'right'; var content_container_margin = parseInt('290p

the problem is that you need to put in-line javascript in CDATA tags if they contain javascript code that could look like html to html parser.


Re: html page typo

Posted: Sun Dec 02, 2012 7:43 am UTC
by Khaoz

You seem to be the only one experiencing this


Unva team fails

Posted: Fri Dec 28, 2012 11:51 am UTC
by epicdude

This does not look promising, when months are needed to fix trivial bug on the web page and still it is not fixed.

Fix the damn
"'); var sidebar_align = 'right'; var content_container_margin = parseInt('290px'); var sidebar_width = parseInt('270px'); //--> " after login bug already, already explained you what you are doing wrong.

Screenshot and explanation why this is, and how to fix:

http://unvanquished.net/forum/showthrea ... -page-typo

Or give me svn to server code I will fix it for you, gee.


Re: Unva team fails

Posted: Fri Dec 28, 2012 1:01 pm UTC
by Gireen

as you say. it's trivial. and it seems you are the only one who has this problem.
so there are more important tasks than this cosmetics aka JavaScript.
If you know in which vBulletin file these typo is tell it and i fix it. Else you must wait until someone gets the time or mood to find and fix it.

ps: which browser do you use?

edit: should be fixed now


Re: html page typo

Posted: Sat Dec 29, 2012 12:07 am UTC
by kharnov

In case anyone's confused, the threads were merged, nothing was deleted.


Re: html page typo

Posted: Sat Dec 29, 2012 2:17 am UTC
by epicdude

Firefox 3.5 and still present, though now you seem to corrected it by adding CDATA tags... hmm wonder why it still doen't work then.