Unvanquished Forum

This thread is purposed to provide a way to request reviews. We have many PRs, many are stalled (sometime for good reasons) and some not but not as prioritised as others, but then as authors, you may be the only one to know what matters for you, or the order you prefer to see them reviewed.

The proposed workflow is to simply write a comment in this thread, stating: “Here are the PRs I need to merge, in that order”, followed with the list of PRs. This is also a way to bring attention so just feel free to “bump” your request by reposting it “I still need attention on this”, etc.

For example you may have multiple PRs that are mergeable, but the pending state of one may prevent you to implement new PRs over it. So you would list that PR in first, even if not the one waiting for the most time.

Here I give an example. Me starting this thread doesn't mean my PRs are more important than other's, also that doesn't mean I consider I don't receive enough review on them (I actually got very good review on them, more than the average). I'm just giving those as an example of what is on the top of my own priority list.

If you need someone else's PR for your own contribution, you can also list it, for example “I need this one: XXX”.

So, I give here my own example:

Here are the PRs I need to merge, in that order:

• https://github.com/DaemonEngine/Daemon/pull/1570
• https://github.com/DaemonEngine/Daemon/pull/1577

I want to merge https://github.com/Unvanquished/Unvanquished/pull/3323. That will finally give us scriptable maps.

I want to merge https://github.com/Unvanquished/Unvanquished/pull/3064

Let's merge https://github.com/DaemonEngine/Daemon/pull/1557 and fix all that horrible oversaturated lighting!

Also I would like a tester for https://github.com/Unvanquished/Unvanquished/pull/3291. Reaper and I couldn't agree on whether it fixes the bug of missiles passing through the

Sweet wrote: ↑Fri Mar 07, 2025 4:50 pm UTC

I want to merge https://github.com/Unvanquished/Unvanquished/pull/3323. That will finally give us scriptable maps.

I changed my mind. Now I want to merge https://github.com/Unvanquished/Unvanquished/pull/3330 instead.

I also have this one:

• https://github.com/DaemonEngine/Daemon/pull/1555

I want to get https://github.com/DaemonEngine/Daemon/pull/1586 , https://github.com/DaemonEngine/Daemon/pull/1593 , and then https://github.com/DaemonEngine/Daemon/pull/1587 merged. That will significantly speed up the development and debugging of shader stuff, esp. with different graphics configurations.

I need to merge this:

• https://github.com/Unvanquished/release-scripts/pull/35

It makes easy to build release builds of the engine using our docker scripts without having to commit the engine submodule.

It makes easier to test arbitrary engine commits for testing on arbitrary systems.