Talk about anything related to Unvanquished.
epicdude
Dretch
Posts: 58 Joined: Thu Nov 01, 2012 3:07 am UTC
Location: Poland, European Union of Communism
Post
by epicdude » Thu Nov 01, 2012 4:27 am UTC
there is text showing:
'); var sidebar_align = 'right'; var content_container_margin = parseInt('290px'); var sidebar_width = parseInt('270px'); //-->
on page http://unvanquished.net/forum/forum.php
there is a typo in HTML code line 100 document write has missplaced closing quoattion mark " and it should be single ' .
<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/sidebar.css?d=1333136741" />
Code: Select all
<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/widgets.css?d=1333136741" />
<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/tagcloud.css?d=1333136741" />
<!--[if lt IE 8]><link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001l/sidebar-ie.css?d=1333136741" /><![endif]-->
<script type="text/javascript">
<!--
document.write('<script type="text/javascript" src="' + yuipath + '/animation/animation-min.js?v=4111"></script>');
var sidebar_align = 'right';
var content_container_margin = parseInt('290px');
velociostrich
Dragoon
Posts: 318 Joined: Thu Mar 08, 2012 6:24 pm UTC
Post
by velociostrich » Fri Nov 02, 2012 4:16 am UTC
I see no typo, and JSLint agrees with me. The only reasonable faults of that code is the missing radix argument to usages of parseInt.
epicdude
Dretch
Posts: 58 Joined: Thu Nov 01, 2012 3:07 am UTC
Location: Poland, European Union of Communism
Post
by epicdude » Fri Nov 02, 2012 1:21 pm UTC
Looks like it was a temporary problem, now works fine.
<N7Reaper> Put your whole fist in
<epicaldude> thats what urmooooom said
epicdude
Dretch
Posts: 58 Joined: Thu Nov 01, 2012 3:07 am UTC
Location: Poland, European Union of Communism
Post
by epicdude » Fri Nov 02, 2012 2:14 pm UTC
Bug is seen again attached
Ok the problem is not quotes (they are o.k.) but the fact that you should use CDATA in javascript blocks that are in line in html.
http://javascript.about.com/library/blxhtml.htm use for #1 or maybe #2, currently you use #3 and this causes problem
Attachments
<N7Reaper> Put your whole fist in
<epicaldude> thats what urmooooom said
epicdude
Dretch
Posts: 58 Joined: Thu Nov 01, 2012 3:07 am UTC
Location: Poland, European Union of Communism
Post
by epicdude » Thu Nov 29, 2012 12:16 pm UTC
Page is still broken, will you fix it?
'); var sidebar_align = 'right'; var content_container_margin = parseInt('290p
the problem is that you need to put in-line javascript in CDATA tags if they contain javascript code that could look like html to html parser.
<N7Reaper> Put your whole fist in
<epicaldude> thats what urmooooom said
Khaoz
Graphic Designer
Posts: 236 Joined: Tue Mar 13, 2012 6:41 am UTC
Location: On the roof
Post
by Khaoz » Sun Dec 02, 2012 7:43 am UTC
You seem to be the only one experiencing this
epicdude
Dretch
Posts: 58 Joined: Thu Nov 01, 2012 3:07 am UTC
Location: Poland, European Union of Communism
Post
by epicdude » Fri Dec 28, 2012 11:51 am UTC
This does not look promising, when months are needed to fix trivial bug on the web page and still it is not fixed.
Fix the damn
"'); var sidebar_align = 'right'; var content_container_margin = parseInt('290px'); var sidebar_width = parseInt('270px'); //--> " after login bug already, already explained you what you are doing wrong.
Screenshot and explanation why this is, and how to fix:
http://unvanquished.net/forum/showthrea ... -page-typo
Or give me svn to server code I will fix it for you, gee.
<N7Reaper> Put your whole fist in
<epicaldude> thats what urmooooom said
Gireen
Graphic Designer
Posts: 295 Joined: Wed Mar 07, 2012 1:26 pm UTC
Clan: [DoH]
Location: Germany
Contact:
Post
by Gireen » Fri Dec 28, 2012 1:01 pm UTC
as you say. it's trivial. and it seems you are the only one who has this problem.
so there are more important tasks than this cosmetics aka JavaScript.
If you know in which vBulletin file these typo is tell it and i fix it. Else you must wait until someone gets the time or mood to find and fix it.
ps: which browser do you use?
edit: should be fixed now
fear ma engrish
kharnov
Granger
Posts: 1851 Joined: Tue Mar 06, 2012 10:54 pm UTC
Clan: GT
Location: New York City
Post
by kharnov » Sat Dec 29, 2012 12:07 am UTC
In case anyone's confused, the threads were merged, nothing was deleted.
epicdude
Dretch
Posts: 58 Joined: Thu Nov 01, 2012 3:07 am UTC
Location: Poland, European Union of Communism
Post
by epicdude » Sat Dec 29, 2012 2:17 am UTC
Firefox 3.5 and still present, though now you seem to corrected it by adding CDATA tags... hmm wonder why it still doen't work then.
<N7Reaper> Put your whole fist in
<epicaldude> thats what urmooooom said